fix: prevent DataCloneError in postMessage serialization #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rack objects When users pass MediaStreamTrack objects as audioSource or videoSource, these were being included directly in call-start-progress event metadata. MediaStreamTrack objects cannot be cloned by the structured clone algorithm used by postMessage, causing DataCloneError during Daily call join. This fix: - Adds describeMediaSource() to convert MediaStreamTrack to serializable strings - Adds sanitizeForPostMessage() for general non-cloneable value handling - Updates call-start-progress events to use describeMediaSource() for metadata - Adds comprehensive tests for serialization utilities Fixes DEVREL-464 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
describeMediaSource()helper to convert MediaStreamTrack objects to serializable string descriptionssanitizeForPostMessage()utility for general non-cloneable value handling (functions, symbols, circular refs)Problem
When a customer passes a custom MediaStreamTrack as
audioSourceorvideoSourceto the Vapi SDK, the SDK includes these objects directly in thecall-start-progressevent metadata. MediaStreamTrack objects cannot be cloned by the structured clone algorithm used bypostMessage, causing aDataCloneErrorduring Daily call join:Solution
Convert non-serializable values (MediaStreamTrack, functions, symbols, etc.) to descriptive strings before including them in event metadata. The actual MediaStreamTrack is still passed to Daily's
createCallObject()- only the diagnostic metadata is sanitized.Test plan
describeMediaSource()functionsanitizeForPostMessage()functionFixes DEVREL-464
Generated with Claude Code